Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support more printf formats #510

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Support more printf formats #510

merged 2 commits into from
Jan 4, 2024

Conversation

kant2002
Copy link
Collaborator

@kant2002 kant2002 commented Jan 3, 2024

No description provided.

@ForNeVeR ForNeVeR self-requested a review January 3, 2024 15:44
@ForNeVeR ForNeVeR self-assigned this Jan 3, 2024
ForNeVeR
ForNeVeR approved these changes Jan 3, 2024
View reviewed changes
Copy link
Owner

@ForNeVeR ForNeVeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a failing test, I see no issues with this code.

Cesium.IntegrationTests/stdlib/io/fprintf.c Outdated Show resolved Hide resolved
@ForNeVeR ForNeVeR assigned kant2002 and unassigned ForNeVeR Jan 3, 2024
ForNeVeR
ForNeVeR approved these changes Jan 4, 2024
View reviewed changes
Copy link
Owner

@ForNeVeR ForNeVeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ForNeVeR ForNeVeR merged commit f05c762 into ForNeVeR:main Jan 4, 2024
3 checks passed
@kant2002 kant2002 deleted the kant/more-printf-formats branch September 8, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ForNeVeR ForNeVeR ForNeVeR approved these changes

Assignees

@kant2002 kant2002

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kant2002 @ForNeVeR